opened 10:53AM - 08 Nov 23 UTC
#657 breaks downloads towards https://api.wordpress.org/ and many other sites wh… en using Curl 7.29.0 (and perhaps other versions)
`Error: RuntimeException: Failed to get url 'https://api.wordpress.org/core/version-check/1.7/?locale=en_US': cURL error 28: Operation timed out after 10000 milliseconds with 807 out of -1 bytes received.`
It also causes issues with the REST API in Site Health with the error: `REST API response: (http_request_failed) cURL error 28: Operation timed out after 10005 milliseconds with XXX out of XXX bytes received”`
It also prevents WordPress plugin and core updates, basically anything that relies on the internal Curl handler in WordPress.
Adding back `Connection: Close` solves the issue. Please revert #657 ASAP and push the fix to WordPress 6.4
Plugin and theme updates show as being slow or timing out post WordPress 6.4 update on sites.
3 Likes
josklever
November 8, 2023, 5:28pm
3
I’ve just tried to patch a site by uploading the Curl.php file without the changes in the breaking PR using the File Uploader Extension. That worked, so if sites can’t update anymore, this could be a workaround.
2 Likes
https://core.trac.wordpress.org/ticket/59842
WordPress:develop ← laszlof:issue-838
opened 05:06PM - 08 Nov 23 UTC
This change rolls back a bug fix from PR #657. This PR contained no test's, and … no real documentation what the issue was it was trying to solve. As a result, this change has broken updates (amongst other things) on at least anyone using curl 7.29.
See Issue #838 for more details.
## Pull Request Type
- [X] I have checked there is no other PR open for the same change.
This is a:
- [X] Bug fix
- [ ] New feature
- [ ] Documentation improvement
- [ ] Code quality improvement
## Context
Roll back a bug fix from PR #657.
## Detailed Description
## Quality assurance
- [X] This change does NOT contain a breaking change (fix or feature that would cause existing functionality to change).
- [X] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have added unit tests to accompany this PR.
- [ ] The (new/existing) tests cover this PR 100%.
- [X] I have (manually) tested this code to the best of my abilities.
- [X] My code follows the style guidelines of this project.
## Documentation
For new features:
- [ ] I have added a code example showing how to use this feature to the [`examples`](https://github.com/WordPress/Requests/tree/develop/examples) directory.
- [ ] I have added documentation about this feature to the [`docs`](https://github.com/WordPress/Requests/tree/develop/docs) directory.
If the documentation is in a new markdown file, I have added a link to this new file to the Docs folder [`README.md`](https://github.com/WordPress/Requests/tree/develop/docs/README.md) file.
<!--
============================================================================================
Please make sure your pull request passes all continuous integration checks!
I.e. code style complies with the project standard, the unit tests pass, code coverage has not gone down.
PRs which are failing their CI checks will likely be ignored by the maintainers.
PRs using atomic, descriptive commits are hugely appreciated as it will make reviewing your changes easier for the maintainers.
============================================================================================
-->
Impacts anything that uses cURL to connect on the site.
opened 01:20PM - 08 Nov 23 UTC
**Describe the bug**
After the WP 6.4 update, several people have reported issu… es with the Stripe plugin:
- [Plugin causing site performance issues after WordPress 6.4 Update](https://wordpress.org/support/topic/plugin-causing-site-performance-issues-after-wordpress-6-4-update/)
- [Not able to access admin with stripe plugin active](https://wordpress.org/support/topic/not-able-to-access-admin-with-stripe-plugin-active/)
- [Plugin causing error wp-admin](https://wordpress.org/support/topic/plugin-causing-error-wp-admin/)
Live mode:
```
Your customers cannot use Stripe on checkout, because we couldn’t connect to your account. Please go to your settings and, set your Stripe account keys.
```
Test mode:
```
There was a problem connecting to the Stripe API endpoint.
```
The backend also slows down and some merchants can't even access the WP-Admin. Downgrading WordPress solves the issue.
**To Reproduce**
Steps to reproduce the behavior:
1. Update WordPress to v6.4
2. Error appears either in live or test mode
**Note:** It's yet unclear what's causing the issue but several people have the same issue and a few said conflict testing didn't help. Myself and a few colleagues are unable to replicate the issue (all on different hosting platforms).
**Expected behavior**
Existing Stripe keys should work after updating to WP 6.4
**Screenshots**
N/A
**Environment (please complete the following information):**
- WordPress Version
- WooCommerce Version
- Stripe Plugin Version
- Browser [e.g. chrome, safari] and Version
- Any other plugins installed
**Additional context**
N/A
josklever
November 8, 2023, 6:10pm
6
You are linking to the bad patch (657) that’s included now in WP 6.4. That change needs to be rolled back. That’s not really clear from your comments.
Removed that link.
Hopefully there is a hotfix for the issue that goes out soon.https://core.trac.wordpress.org/ticket/59842#comment:3
1 Like
josklever
November 8, 2023, 6:47pm
8
They’ll probably need to change something on the wp.org side, because sites with this issue can’t get updates, but we’ll see and otherwise I’ll use the File Uploader extension.
1 Like
Manual patch is in this link.
opened 10:53AM - 08 Nov 23 UTC
#657 breaks downloads towards https://api.wordpress.org/ and many other sites wh… en using Curl 7.29.0 (and perhaps other versions)
`Error: RuntimeException: Failed to get url 'https://api.wordpress.org/core/version-check/1.7/?locale=en_US': cURL error 28: Operation timed out after 10000 milliseconds with 807 out of -1 bytes received.`
It also causes issues with the REST API in Site Health with the error: `REST API response: (http_request_failed) cURL error 28: Operation timed out after 10005 milliseconds with XXX out of XXX bytes received”`
It also prevents WordPress plugin and core updates, basically anything that relies on the internal Curl handler in WordPress.
Adding back `Connection: Close` solves the issue. Please revert #657 ASAP and push the fix to WordPress 6.4
# If you are just looking to fix the cURL timeouts issue in WordPress 6.4 Read here:
To fix the issue, replace `/wp-includes/Requests/src/Transport/Curl.php` with the following file: [Curl.php.zip](https://github.com/WordPress/Requests/files/13300252/Curl.php.zip)
WordPress 6.4.1 should be released later this evening.
1 Like
api.wordpress.org should be working as expected as well on sites running WordPress 6.4.1.
1 Like
The RC for WordPress 6.4.1 has been released.
1 Like
josklever
November 10, 2023, 12:19am
15
@techmagick It was a change in WordPress, that surfaced existing issues at hosting companies. But not just old versions as I’ve seen sites with more recent versions that were affected as well. They are still researching the real cause, so I’ve already told that to the writer of that article, who said he would update it. If you read the discussions in the trac/github tickets and on Slack you can learn more details.
1 Like
system
December 10, 2023, 9:32pm
17
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.