Rank Math and WP Rocket plugins seem to running into pending actions issues with the recent Action Scheduler update

sebastian-moran · September 16, 2022, 8:01pm

[WIP] Action Scheduler: lots of past-due rocket_preload_job_preload_url actions found

opened 12:01AM - 15 Sep 22 UTC

closed 10:25AM - 21 Sep 22 UTC

type: bug module: preload priority: high severity: moderate

**Before submitting an issue please check that you’ve completed the following st…eps:** yes - Made sure you’re on the latest version yes - Used the search feature to ensure that the bug hasn’t been reported before **Describe the bug** @webtrainingwheels noticed a trend: On some sites using **3.12.0.5** the `rocket_preload_job_preload_url` starts piling up. (6k, 70k, 80k entries) Users are mentioning the entries are being created really fast. Some cases are using **Rank Math SEO** as a common factor, but I can't confirm it is related `Action Scheduler: 70197 past-due actions found; something may be wrong. Read documentation »" In clicking through, there are indeed many many "Rocket Preload" actions in Pending in Scheduled actions. ` In one case where we have access, the only `action_scheduler_queue_runner_concurrent_batches` is ours, and set to 1 there are under 5k posts, but over 60k `rocket_preload_job_preload_url` **Additional context** Related tickets: https://secure.helpscout.net/conversation/2009676957/368580/ https://secure.helpscout.net/conversation/2009655193/368571/ https://secure.helpscout.net/conversation/2006498141/367846 https://secure.helpscout.net/conversation/2009599555/368564 https://secure.helpscout.net/conversation/2009599415/368563 Slack convo: https://wp-media.slack.com/archives/C43T1AYMQ/p1663195462029489 **Backlog Grooming (for WP Media dev team use only)** - [ ] Reproduce the problem - [ ] Identify the root cause - [ ] Scope a solution - [ ] Estimate the effort

sebastian-moran · September 20, 2022, 6:43pm

github.com/wp-media/wp-rocket

Hide past due actions in Action Scheduler

opened 10:19AM - 20 Sep 22 UTC

closed 10:25AM - 21 Sep 22 UTC

piotrbak

type: enhancement module: preload priority: high module: remove unused css

**Before submitting an issue please check that you’ve completed the following st…eps:** - Made sure you’re on the latest version - Used the search feature to ensure that the bug hasn’t been reported before **Describe the bug** Since Action Scheduler 3.5 version, users can see a tab with past-due actions. This doesn't play well with async actions, as the date can not be set and it ends up with filling the tab with all our actions and confusing our customers. **To Reproduce** Steps to reproduce the behavior: 1. Enable preload 2. All actions are being added to `Pending` tab and `Past-due` **Expected behavior** The fix needs to be implemented on the Action Scheduler side. From our point of view, we should hide this tab as we're flooded with tickets from confused customers. **Backlog Grooming (for WP Media dev team use only)** - [ ] Reproduce the problem - [ ] Identify the root cause - [ ] Scope a solution - [ ] Estimate the effort

github.com/wp-media/wp-rocket

Temporarily Hide action scheduler past due

wp-media:develop ← wp-media:fix/hide_action_scheduler_pastdue

opened 11:12AM - 20 Sep 22 UTC

engahmeds3ed

+88 -0

## Description We need to hide the past due admin notice from Action Schedule…r in case the users has the latest version of Action Scheduler used at any other plugin not to confuse them. The main problem is inside Action Scheduler itself, because Async tasks don't have schedule date and just have zeros/null value so the following query which gets the past due actions: https://github.com/woocommerce/action-scheduler/blob/trunk/classes/ActionScheduler_AdminView.php#L154-L158 needs some adjustment to only get the rows that have real dates there. We need to keep our eyes on action scheduler code base to see if this issue is solved there to revert this PR's changes. Also we will try contributing there to help getting this fix as soon as possible. Fixes #5450 ## Type of change Please delete options that are not relevant. - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (non-breaking change which improves an existing functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## Is the solution different from the one proposed during the grooming? Not groomed. ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [x] Unit tests - [x] Manual testing # Checklist: Please delete the options that are not relevant. - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules

sebastian-moran · September 20, 2022, 6:44pm

github.com/woocommerce/action-scheduler

Past-due tab seems not to be working correctly with asynchronous actions

opened 04:58PM - 20 Sep 22 UTC

piotrbak

type: enhancement priority: low

We use Action Scheduler to register many async actions at the same time. Since 3….5 update of Action Scheduler all our actions are set to `past-due` **just** after being scheduled and it's very confusing for our customers. It looks like this update doesn't play well with async actions as the date for them can't be set: ``` array ( 'hook' => 'async_request_url', 'status' => 'pending', 'scheduled_date_gmt' => '0000-00-00 00:00:00', 'scheduled_date_local' => '0000-00-00 00:00:00', 'schedule' => 'O:28:"ActionScheduler_NullSchedule":0:{}', 'group_id' => 10, ) ``` Is that something you are aware of, or maybe we're missing the point here?

system · October 20, 2022, 6:44pm

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.